Re-add removed methods #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two methods were mistakenly removed from both Beaker and beaker-puppet, breaking tests for modules. puppet_agent_dev_package_info was removed in Beaker in voxpupuli/beaker@cdaedad under the mistaken assumption that it had already been moved over to beaker-puppet. install_puppet_agent_dev_repo_on was removed in beaker-puppet in 22a38c8 because it relied on puppet_agent_dev_package_info, which was no longer available. This commit restores those two methods (with some minor modifications for platforms that are no longer supported) and their associated tests.
|
I think I misunderstood the test failures I was seeing and this isn't actually necessary. Closing out PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two methods were mistakenly removed from both Beaker and beaker-puppet, breaking tests for modules.
puppet_agent_dev_package_info was removed in Beaker in voxpupuli/beaker@cdaedad under the mistaken assumption that it had already been moved over to beaker-puppet.
install_puppet_agent_dev_repo_on was removed in beaker-puppet in 22a38c8 because it relied on puppet_agent_dev_package_info, which was no longer available.
This commit restores those two methods (with some minor modifications for platforms that are no longer supported) and their associated tests.