(maint) Update acceptance to fix windows ruby install #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
approved these changes
Jul 18, 2023
A couple things have changed about ruby and chocolatey, requiring new changes to ensure the windows installation can succeed. The newest versions of chocolately no longer require the `--lo` flag in the choco list command, because that command now only lists local packages instead of doing any remote searching. Remove use of the flag so acceptance setup can complete Update the ruby installation to use latest ruby, version 2.5 was unable to build with new changes to the ruby devkit. Add new steps to install msys2 and run ridk to install the ruby devkit, which is required to build gems with C extensions
mcdonaldseanp
force-pushed
the
fix_acceptance
branch
from
3d90377
to
c7be7f9
Compare
mcdonaldseanp
changed the title
-lo option from choco list
donoghuc
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple things have changed about ruby and chocolatey, requiring new
changes to ensure the windows installation can succeed.
The newest versions of chocolately no longer require the
--loflag inthe choco list command, because that command now only lists local
packages instead of doing any remote searching.
Remove use of the flag so acceptance setup can complete
Update the ruby installation to use latest ruby, version 2.5 was unable
to build with new changes to the ruby devkit.
Add new steps to install msys2 and run ridk to install the ruby devkit,
which is required to build gems with C extensions