(GH-3286) Add file::delete() function
#3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more note wrt this.. I guess it'd be nice to add another function signature like |
Closes puppetlabs#3286 !feature * **Add `file::delete()` function** Delete a file on localhost using ruby's `File.delete`. This will only delete files on the machine you run Bolt on.
bastelfreak
reviewed
Mar 30, 2024
| Puppet.lookup(:bolt_executor) {}&.report_function_call(self.class.name) | ||
|
|
||
| File.delete(filename) | ||
| nil |
There was a problem hiding this comment.
why nil here, do you always want to return nil and not the result of delete()?
There was a problem hiding this comment.
That was copied from file::write() actually.. In our case delete() will always return 1 (number of filenames passed as the arguments). Not sure how useful it is.
|
This looks good. I'll need to look in to the integration tests and docs actions. I'll do that in a separate PR. |
donoghuc
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3286
!feature
file::delete()function Delete a file on localhost using ruby'sFile.delete. This will only delete files on the machine you run Bolt on.