(GH-3309) Ensure bundled-ruby defaults are applied at target init #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
force-pushed
the
apply-local-defaults
branch
from
aaa845f
to
8122178
Compare
…t init Previously defaults were not applied until an action was actually requested on a target. This made inventory resolution confusing and non-determanistic behavior with apply_prep. This commit moves application of defaults for a target to the init method for creating a target object. !bug * **Apply bundled-ruby defaults at target creation** ([puppetlabs#3309](3309)) Ensure defaults associated with `bundled-ruby` transport config are applied at target initialization.
donoghuc
force-pushed
the
apply-local-defaults
branch
from
8122178
to
4ea4d1d
Compare
mcdonaldseanp
approved these changes
May 13, 2024
|
Yeah, i think this is a subtle one that is easy to not be noticed. I think i understand the sentiment around deferring before adding the defaults, bug given it changes the state of the target we need to ensure it happens consistently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously defaults were not applied until an action was actually requested on a target. This made inventory resolution confusing and non-determanistic behavior with apply_prep. This commit moves application of defaults for a target to the init method for creating a target object.
!bug
Apply bundled-ruby defaults at target creation (#3309)
Ensure defaults associated with
bundled-rubytransport config are applied at target initialization.