Fix with latest version of yard #3354
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
fix-ci-with-latest-yard
branch
2 times, most recently
from
55f2170
to
9e05d69
Compare
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke bolt. A workaround was proposed in puppetlabs#3349 but the root cause was not addressed. Detect if the version of YARD we are using provide the `YARD::Logger::Severity` class (part of the new interal API) and if so use its constants to set the log level, otherwise fallback to the previous way of setting the log level using a Symbol. While here, revert the workaround that was committed in puppetlabs#3349 and puppetlabs#3350. !no-release-note
smortex
force-pushed
the
fix-ci-with-latest-yard
branch
from
9e05d69
to
c8c7574
Compare
|
Cc @donoghuc as he authored the workaround and will probably be interested in a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkey patching libraries is a bad idea. Latest version of yard changed
some internal details, which broke bolt.
A workaround was proposed in #3349 but the root cause was not addressed.
Detect if the version of YARD we are using provide the
YARD::Logger::Severityclass (part of the new interal API) and if souse its constants to set the log level, otherwise fallback to the
previous way of setting the log level using a Symbol.
While here, revert the workaround that was committed in #3349 and #3350.