Fix virtual resolution on Illumos LX
#2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Thank you for this PR @smokris , I have added it to our internal backlog for us to look at and triage. |
mhashizume
approved these changes
Nov 1, 2024
|
Could you rebase to pull in the changes from #2775 ? Thanks! |
smokris
force-pushed
the
container-illumos-lx-zone
branch
from
a9b13e9 to
b220868
Compare
Sure, I rebased it just now. |
|
Ah sorry, one more rebase for the changes in #2776 to fix that unrelated Rubocop error |
…er::Util::Facts::Posix::VirtualDetector#check_illumos_lx is executed
smokris
force-pushed
the
container-illumos-lx-zone
branch
from
b220868 to
31d32da
Compare
|
No problem; I rebased it again. |
|
Thanks again @smokris ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an Illumos LX zone, prior to 7bc38cc:
After 7bc38cc:
The problem is that
Facter::Resolvers::Containersnow returns a value, causingFacter::Util::Facts::Posix::VirtualDetector#platformto return that value instead of executing#check_illumos_lx.This PR fixes that, and adds a test.
With this PR: