Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FORGE-575) Updates for Faraday 1.x #86

Merged
merged 5 commits into from
Jan 28, 2021
Merged

(FORGE-575) Updates for Faraday 1.x #86

merged 5 commits into from
Jan 28, 2021

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jan 28, 2021 •
edited
Loading

Updates Ruby dependency to >= 2.4.0, updates Faraday dependencies to the 1.x series. Updates code and tests to be compatible with new versions.

@scotje scotje requested a review from a team as a code owner January 28, 2021 20:40
nkanderson
nkanderson approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@nkanderson nkanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scotje scotje merged commit dddc81b into puppetlabs:main Jan 28, 2021
@scotje scotje deleted the forge575_update_faraday branch January 28, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkanderson nkanderson nkanderson approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotje @nkanderson @dinesh-gujar