Do not reveal sensitive Data #1597
Open
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocker-cc
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
bastelfreak
approved these changes
May 10, 2024
deric
approved these changes
May 13, 2024
smortex
approved these changes
May 13, 2024
SimonHoenscheid
approved these changes
May 16, 2024
"auth_option" may contain sensitive Data, f.e. LDAP-Password. So let auth_option accept Puppet-Type Sensitive. The consuming EPP is able to handle sensitive Data natively, and will return the rendered Template as Sensitive[String] then, which the Resource "file" also is able to handle.
cocker-cc
force-pushed
the
Sensitive_Data
branch
from
bb77bb2
to
6ce2cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
auth_optionmay contain sensitive Data, f.e. LDAP-Password. So letauth_optionaccept Puppet-TypeSensitive. The consuming EPP is able to handle sensitive Data natively, and will return the rendered Template asSensitive[String]then, which the Resourcefilealso is able to handle.Checklist
pdk validatepdk test unit