Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable persistence of var-dir and confd volumes #230

Merged
merged 5 commits into from
May 9, 2024

Conversation

cpiment
Copy link
Contributor

@cpiment cpiment commented May 3, 2024

Solves #220

Adds these two parameters to the chart:

.Values.puppetserver.persistence.data.enabled
.Values.puppetserver.persistence.confd.enabled

With the default value to true to keep the current chart behaviour, but if they are changed to false, they disable the use of persistent volumes for

/opt/puppetlabs/server/data/puppetserver/
/etc/puppetlabs/puppetserver/conf.d/

This simplifies the multi-master and multi-compilers architecture because less volumes have to be shared between pods.

Copy link
Contributor

@Xtigyro Xtigyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpiment Sweet - thank you!

Since this a new feature, would you mind please bumping not the bugfix version but the minor version of the chart - e.g. 9.5.0?

The update command for the Unit tests will need to be re-run too.

@cpiment cpiment requested a review from Xtigyro May 9, 2024 09:15
@cpiment
Copy link
Contributor Author

cpiment commented May 9, 2024

I have implemented the requested changes. Thanks!

Copy link
Contributor

@Xtigyro Xtigyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpiment Thank you!

@Xtigyro
Copy link
Contributor

Xtigyro commented May 9, 2024

@cpiment Lemme know please when you're ready at some later point to submit something similar: #231 😋

@Xtigyro Xtigyro merged commit 6d9aff6 into puppetlabs:master May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants