(PE-38293) Fix test for modified error message with new Bouncy Castle #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally with new clj-parent and this fixes the test failure |
nmburgan
force-pushed
the
issue/main/pe-38293_fix_test_for_new_bouncycastle
branch
from
5297bfd
to
1f5339b
Compare
|
closing and re-opening to try and kick this against the recent clj-parent bump |
|
@nmburgan , looks like we need to make the final dashes in the exception message optional. Doesn't look like the FIPS jars have been updated with the improved error message yet. |
justinstoller
requested changes
Jul 16, 2024
nmburgan
force-pushed
the
issue/main/pe-38293_fix_test_for_new_bouncycastle
branch
from
1f5339b
to
2e5af50
Compare
|
Updated |
justinstoller
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.