Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler.rb: Switch to modern facts #2878

Closed
wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Contributor

All of those are available at least since Facter 3.

All of those are available at least since Facter 3.
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also take the chance to look at a new structured fact called puppetserver and add all the values in there.

You can probably be smart and align the facts to networking facts:

# Copy networking facts if available
['fqdn', 'ip', 'ip6'].each do |var|
  if (value = Facter.value("networking.#{var}"))
    @server_facts[var] = value
  end
end

@justinstoller
Copy link
Member

Closing in favor of #2894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants