Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-39250) Remove project APIs and configuration #2882

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mcdonaldseanp
Copy link
Contributor

Removes access to file_metadata and compile options which allowed fetching data and compiling for bolt projects. This commit does not remove all project based code, it is restricted to covering enough ground to remove access to any functionality, but there may still be some internal code left over.

@mcdonaldseanp mcdonaldseanp requested review from a team as code owners September 25, 2024 17:32
@justinstoller
Copy link
Member

It looks like there was some spec updates made as part of 9cb17ad that still reference projects. I know this PR wasn't meant to get rid of everything, but I'm surprised the specs are passing with this change.

@mcdonaldseanp
Copy link
Contributor Author

@justinstoller are you referrring to the ruby specs? if so there weren't any significant changes to the ruby code for compiling projects, so the tests will still pass.

Also I have no idea why linting is failing on a file I've not made any changes to

@steveax
Copy link
Contributor

steveax commented Oct 1, 2024

latest kondo gets downloaded during the action run, so if there's a new version it'll sometimes carp about something that hasn't been touched

@donoghuc
Copy link
Member

donoghuc commented Oct 1, 2024

Those kondo fixes were fixed in 7.x and will be merged up https://github.com/puppetlabs/puppetserver/pull/2880/files

@mcdonaldseanp
Copy link
Contributor Author

Yeah @justinstoller I don't expect that to fail. The ruby AST compiler can still compile in a project, I just removed access to that code through the API

@justinstoller
Copy link
Member

These are the code deletions I was hoping for. But it looks like there's some additional tests that need to go with it.

Removes access to file_metadata and compile options which allowed
fetching data and compiling for bolt projects. This commit does not
remove all project based code, it is restricted to covering enough
ground to remove access to any functionality, but there may still be
some internal code left over.
@justinstoller justinstoller merged commit 6efb46b into puppetlabs:main Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants