-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PE-39250) Remove project APIs and configuration #2882
Conversation
I assume this can also go: https://github.com/puppetlabs/puppetserver/pull/2882/files#diff-b0f611aa58814be93f011d5e22ed06752df5baf8fd4f2e960d882171a3fb4d13R966 ? I believe if that goes then this file can go https://github.com/puppetlabs/puppetserver/blob/main/src/clj/puppetlabs/services/master/file_serving.clj |
It looks like there was some spec updates made as part of 9cb17ad that still reference projects. I know this PR wasn't meant to get rid of everything, but I'm surprised the specs are passing with this change. |
b731518
to
896178b
Compare
@justinstoller are you referrring to the ruby specs? if so there weren't any significant changes to the ruby code for compiling projects, so the tests will still pass. Also I have no idea why linting is failing on a file I've not made any changes to |
latest kondo gets downloaded during the action run, so if there's a new version it'll sometimes carp about something that hasn't been touched |
Those kondo fixes were fixed in 7.x and will be merged up https://github.com/puppetlabs/puppetserver/pull/2880/files |
Yeah @justinstoller I don't expect that to fail. The ruby AST compiler can still compile in a project, I just removed access to that code through the API |
9ba65b0
to
58f6bbf
Compare
These are the code deletions I was hoping for. But it looks like there's some additional tests that need to go with it. |
Removes access to file_metadata and compile options which allowed fetching data and compiling for bolt projects. This commit does not remove all project based code, it is restricted to covering enough ground to remove access to any functionality, but there may still be some internal code left over.
58f6bbf
to
6bb7e31
Compare
Removes access to file_metadata and compile options which allowed fetching data and compiling for bolt projects. This commit does not remove all project based code, it is restricted to covering enough ground to remove access to any functionality, but there may still be some internal code left over.