Support dot-notation when retrieving facts in facter_impl #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 15, 2023
alexjfisher
force-pushed
the
facter_impl_dot_notation
branch
from
10992f0
to
6a6d2ff
Compare
In Puppet 8, core providers are being confined using facts fetched using
'dot-notation'. We need to support this style of lookup in our stub
implementation.
For example in `lib/puppet/provider/service/init.rb`
```ruby
confine :true => begin
os = Puppet.runtime[:facter].value(:operatingsystem).downcase
# ...
```
was updated to
```ruby
confine :true => begin
os = Puppet.runtime[:facter].value('os.name').downcase
# ...
```
See
puppetlabs/puppet@82cef23 for Puppet 8 change.
Relates to puppetlabs#38
alexjfisher
force-pushed
the
facter_impl_dot_notation
branch
from
6a6d2ff
to
074363e
Compare
ekohl
approved these changes
Mar 15, 2023
| @@ -8,7 +8,11 @@ def initialize | |||
| end | |||
|
|
|||
| def value(fact_name) | |||
| @facts[fact_name.to_s] | |||
| begin | |||
There was a problem hiding this comment.
I'm so used to Ruby 2.5+ where you can write:
def
@facts.dig(*fact_name.to_s.split('.'))
rescue TypeError
nil
endBut this gem doesn't declare to be Ruby 2.5+ so I think your current code is fine.
jhoblitt
approved these changes
Mar 15, 2023
chelnak
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Puppet 8, core providers are being confined using facts fetched using 'dot-notation'. We need to support this style of lookup in our stub implementation.
For example in
lib/puppet/provider/service/init.rbwas updated to
See
puppetlabs/puppet@82cef23 for Puppet 8 change.
Relates to #38