(PA-5786) Add ability to execute direct post installation scripts #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `#add_postinstall_action` adds actions to the `%posttrans` section of an rpm spec file. This can mean that the action could fail, but the installation/upgrade could still succeed. This commit adds the ability to add actions that must succeed post installation for rpm installations by adding the action to the `%post` section. A previous attempt to add this was done in 93ba1b4; that introduced a bug where the install and upgrade files were incorrectly deleted after the %post step. They needed to remain so that the %posttrans rpm section would detect the install/upgrade via vanagon's
|
Should wait until releases are live before merging/releasing this. |
|
@e-gris I think this should be good to merge and release now? |
|
Today or tomorrow, just sorting through post-release priorities. |
e-gris
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
#add_postinstall_actionadds actions to the%posttranssection of an rpm spec file. This can mean that the action could fail, but the installation/upgrade could still succeed. This commit adds the ability to add actions that must succeed post installation for rpm installations by adding the action to the%postsection.A previous attempt to add this was done in 93ba1b4; that introduced a bug where the install and upgrade files were incorrectly deleted after the %post step. They needed to remain so that the %posttrans rpm section would detect the install/upgrade via vanagon's
Please add all notable changes to the "Unreleased" section of the CHANGELOG.