Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(vanagon-238) Fix rubocop offence and workflow issue #835

Merged
merged 1 commit into from
Jan 22, 2024
Merged

(vanagon-238) Fix rubocop offence and workflow issue #835

merged 1 commit into from
Jan 22, 2024

Conversation

amitkarsale
Copy link
Contributor

@amitkarsale amitkarsale commented Jan 17, 2024 •
edited
Loading

ruby 2.7 is compatible with <= bundler 2.4.22. Latest version of bundler is causing failures in checks.

@amitkarsale amitkarsale force-pushed the VANAGON-238 branch 4 times, most recently from 3a9deb5 to 68a90da Compare January 17, 2024 06:59
@amitkarsale amitkarsale marked this pull request as ready for review January 17, 2024 07:01
@amitkarsale amitkarsale requested review from a team as code owners January 17, 2024 07:01
amitkarsale
amitkarsale commented Jan 17, 2024
View reviewed changes
lib/vanagon/platform.rb Outdated Show resolved Hide resolved
amitkarsale
amitkarsale commented Jan 17, 2024
View reviewed changes
lib/vanagon/platform.rb Outdated Show resolved Hide resolved
e-gris
e-gris reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@e-gris e-gris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I don't think we should do this.

I've added some individual comments.

lib/vanagon/engine/base.rb Outdated Show resolved Hide resolved
lib/vanagon/platform.rb Outdated Show resolved Hide resolved
lib/vanagon/platform.rb Outdated Show resolved Hide resolved
lib/vanagon/platform/defaults/sles-11-x86_64.rb Outdated Show resolved Hide resolved
@amitkarsale amitkarsale force-pushed the VANAGON-238 branch 2 times, most recently from 80ce76b to 06b79d0 Compare January 18, 2024 08:55
@amitkarsale amitkarsale changed the title (vanagon-238) Add SLES11 x86_64 (vanagon-238) Fix rubocop offence and workflow issue Jan 18, 2024
@amitkarsale
Copy link
Contributor Author

Hello @e-gris , Can we merge this now.

e-gris
e-gris approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@e-gris e-gris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval contingent on my one comment. Thanks for doing this.

lib/vanagon/engine/base.rb Outdated Show resolved Hide resolved
@amitkarsale amitkarsale merged commit 4aa447c into puppetlabs:main Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-gris e-gris e-gris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitkarsale @e-gris