-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize fetch to use local download #848
Open
h0tw1r3
wants to merge
8
commits into
puppetlabs:main
Choose a base branch
from
h0tw1r3:optimize-fetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change is sorely needed to implement a rudimentary local source cache. very useful between builds with docker. |
h0tw1r3
force-pushed
the
optimize-fetch
branch
3 times, most recently
from
August 4, 2024 16:19
e8deeb4
to
6cc9ceb
Compare
discovered when running test suite with ruby:3.2 image on docker
v3 is deprecated and produces a warning message
removed cops are provided by gems not explicitly installed they seem to be installed using the setup ruby action, but not when testing in a ruby docker image either way, they are covered by enabling newcops
if source is already downloaded and can be verified, skip downloading again.
rebased on #857 so tests will pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly improves the efficiency of testing local rebuilds by reusing the same workdir.