Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize fetch to use local download #848

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 17, 2024

Greatly improves the efficiency of testing local rebuilds by reusing the same workdir.

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Aug 4, 2024

this change is sorely needed to implement a rudimentary local source cache. very useful between builds with docker.

puppetlabs/puppet#9305

@h0tw1r3 h0tw1r3 force-pushed the optimize-fetch branch 3 times, most recently from e8deeb4 to 6cc9ceb Compare August 4, 2024 16:19
discovered when running test suite with ruby:3.2 image on docker
v3 is deprecated and produces a warning message
removed cops are provided by gems not explicitly installed
they seem to be installed using the setup ruby action, but not
when testing in a ruby docker image

either way, they are covered by enabling newcops
if source is already downloaded and can be verified, skip downloading again.
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Aug 4, 2024

rebased on #857 so tests will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant