(VANAGON-257) Enable windowsfips-2016 to use '-fips' candle and heat … #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamshinde360
force-pushed
the
VANAGON-257
branch
2 times, most recently
from
f845e46
to
a22f95b
Compare
bastelfreak
reviewed
Aug 27, 2024
shubhamshinde360
force-pushed
the
VANAGON-257
branch
from
a22f95b
to
87a7a82
Compare
shubhamshinde360
force-pushed
the
VANAGON-257
branch
3 times, most recently
from
93bde85
to
9794f4d
Compare
joshcooper
reviewed
Aug 27, 2024
shubhamshinde360
force-pushed
the
VANAGON-257
branch
from
9794f4d
to
4e2c680
Compare
joshcooper
reviewed
Aug 27, 2024
shubhamshinde360
force-pushed
the
VANAGON-257
branch
from
4e2c680
to
01ad51a
Compare
|
Thanks for your suggestions @joshcooper! |
joshcooper
reviewed
Aug 27, 2024
joshcooper
reviewed
Aug 27, 2024
…flags - Fix some rubocop complaints. - Some cops were moved to separate gem and renamed. Require these gems and update the names. - Remove unused rails cops.
shubhamshinde360
force-pushed
the
VANAGON-257
branch
from
01ad51a
to
d12e71e
Compare
isaac-hammes
approved these changes
Aug 28, 2024
e-gris
reviewed
Aug 28, 2024
| @@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org). | |||
| This changelog adheres to [Keep a CHANGELOG](https://keepachangelog.com). | |||
|
|
|||
| ## [Unreleased] | |||
| - (VANAGON-257) Enable windowsfips-2016 to use '-fips' candle and heat flags. | |||
There was a problem hiding this comment.
Put this under an '### Added' section
shubhamshinde360
added a commit
to shubhamshinde360/vanagon
that referenced
this pull request
Aug 28, 2024
- The error was introduced in puppetlabs#860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at flags