Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(VANAGON-257) Enable windowsfips-2016 to use '-fips' candle and heat … #860

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

shubhamshinde360
Copy link
Contributor

…at flags

@shubhamshinde360 shubhamshinde360 requested review from a team as code owners August 23, 2024 06:28
@shubhamshinde360 shubhamshinde360 marked this pull request as draft August 23, 2024 06:32
@shubhamshinde360 shubhamshinde360 force-pushed the VANAGON-257 branch 2 times, most recently from f845e46 to a22f95b Compare August 27, 2024 07:31
@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review August 27, 2024 07:35
Gemfile Outdated Show resolved Hide resolved
@shubhamshinde360 shubhamshinde360 marked this pull request as draft August 27, 2024 08:00
@shubhamshinde360 shubhamshinde360 force-pushed the VANAGON-257 branch 3 times, most recently from 93bde85 to 9794f4d Compare August 27, 2024 09:44
@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review August 27, 2024 09:48
Gemfile Outdated Show resolved Hide resolved
@shubhamshinde360
Copy link
Contributor Author

Thanks for your suggestions @joshcooper!
I have incorporated them.

@shubhamshinde360 shubhamshinde360 marked this pull request as ready for review August 27, 2024 16:50
…flags

 - Fix some rubocop complaints.
 - Some cops were moved to separate gem and renamed. Require these gems and update the names.
 - Remove unused rails cops.
@shubhamshinde360 shubhamshinde360 merged commit 64d38ab into puppetlabs:main Aug 28, 2024
5 checks passed
@@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org).
This changelog adheres to [Keep a CHANGELOG](https://keepachangelog.com).

## [Unreleased]
- (VANAGON-257) Enable windowsfips-2016 to use '-fips' candle and heat flags.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this under an '### Added' section

shubhamshinde360 added a commit to shubhamshinde360/vanagon that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants