Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry or fail when passport fails to upload to R2 #47

Open
MatthewStanciu opened this issue Sep 12, 2024 · 0 comments
Open

Retry or fail when passport fails to upload to R2 #47

MatthewStanciu opened this issue Sep 12, 2024 · 0 comments

Comments

@MatthewStanciu
Copy link
Member

MatthewStanciu commented Sep 12, 2024 •
edited
Loading

passport-issuing-office/lib/actions.ts

Line 52 in 7c85086

await fetch(preSignedUrl, {

72.png just failed to upload, but 72-full.png succeeded. The failure of 72.png was not caught because errors are not handled.

If the request to R2 does not return 200, then it should retry once, then fail on the user's end.

Steps to close

  • Handle errors and display to user in a JavaScript alert
  • Display the errors in a modal or toast
@MatthewStanciu MatthewStanciu changed the title Retry or fail when passport fails to upload Retry or fail when passport fails to upload to R2 Sep 12, 2024
This was referenced Sep 12, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthewStanciu