Handle R2 upload errors #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TheShadowEevee
approved these changes
Sep 12, 2024
| @@ -29,7 +29,7 @@ export async function POST(request: Request) { | |||
| portrait: portraitImage, | |||
| sendToDb: sendToDb === "true", | |||
| }, | |||
| request.url, | |||
There was a problem hiding this comment.
Small nit, is there a reason some extra commas were removed? I'm not going to comment on every one of these
Edit: Didn't finish my comment! I was gonna say there's three more instances of commas being removed in actions.ts
There was a problem hiding this comment.
My Prettier did that, is it out of line with the project settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #47
A future PR will display this error in a toast or modal instead of JavaScript alert, but want to get error handling out first since people are running into this.
Another future PR will prevent the website from crashing if the image doesn't load.