Review feedback

purescript · Aug 29, 2024 · fc3069b · fc3069b
1 parent bcc2960
commit fc3069b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/src/SSH.purs b/lib/src/SSH.purs
@@ -54,7 +54,6 @@ printParsePrivateKeyError = case _ of
   RequiresPassphrase -> "Encrypted private key requires a passphrase"
   OtherParseError message -> message
 
--- | Parse a password-protected private SSH key
 parsePrivateKey :: { key :: String, passphrase :: Maybe String } -> Either ParsePrivateKeyError PrivateKey
 parsePrivateKey { key, passphrase } =
   case runFn4 parseKeyImpl (Left <<< Exception.message) Right key (Nullable.toNullable passphrase) of
@@ -103,7 +102,7 @@ foreign import equalsImpl :: Fn2 ParsedKey ParsedKey Boolean
 
 foreign import publicToOwnerImpl :: Fn1 PublicKey { keytype :: String, public :: String, id :: Nullable String }
 
-publicToOwner :: PublicKey -> Owner
-publicToOwner key = do
+publicKeyToOwner :: PublicKey -> Owner
+publicKeyToOwner key = do
   let { id: nullableId, keytype, public } = runFn1 publicToOwnerImpl key
   Owner { keytype, public, id: Nullable.toMaybe nullableId }
diff --git a/lib/test/Registry/SSH.purs b/lib/test/Registry/SSH.purs
@@ -26,7 +26,7 @@ spec = do
   Spec.it "Parses a password-protected RSA private key" do
     case SSH.parsePrivateKey { key: id_rsa, passphrase: Nothing } of
       Left err1@SSH.RequiresPassphrase -> do
-        SSH.printParsePrivateKeyError err1 `Assert.shouldEqual` "Encrypted private OpenSSH key detected, but no passphrase given"
+        SSH.printParsePrivateKeyError err1 `Assert.shouldEqual` "Encrypted private key requires a passphrase"
         case SSH.parsePrivateKey { key: id_rsa, passphrase: Just id_rsa_password } of
           Left err2 -> Assert.fail $ "Failed to parse id_rsa private key with password: " <> SSH.printParsePrivateKeyError err2
           Right _ -> pure unit