-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API pipeline #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Honeyman <[email protected]>
f-f
commented
Mar 26, 2021
Co-authored-by: Thomas Honeyman <[email protected]>
Co-authored-by: Thomas Honeyman <[email protected]>
I just realized we should forbid here the use of build metadata in the package version, as we agreed in #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
As per title, this PR implements and deploys a first working version of the main CI pipeline that implements the backend of the Registry API.
Rough summary of what happens in the pipeline:
Things not in scope for this PR
Can I publish packages after we merge this?
No. Because:
Manifest
schema before that (e.g. Manifest description #124)How to review this
TODO
s left in the code are not supposed to be tackled now, they are either not urgent to get this off the ground, or just placeholders for future code. Some things we are not implementing now:Addition
andUpgrade
operations are implement, noUnpublish
yet (we'll likely need to tackle Package maintainers #155 first)git
thingy" to pull packages from, for now we only support GitHubci/src/Registry/API.purs
, everything else is built to support thatBowerImport
module, I'll heavily refactor that in the next PR anywaysTicket bureaucracy
Fixes #96, fixes #3, fixes #16, fixes #23