Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional authentication methods - Oauth #29
base: main
Are you sure you want to change the base?
Support additional authentication methods - Oauth #29
Changes from 15 commits
0ecc411
de3f94f
2c4400e
b79b946
a247db1
7c5ce31
609eb66
6ee285d
2dce377
e78ffda
f60bb83
46027e2
fc6bc82
393d586
69970e4
cee8001
0504528
364e522
a06fe24
1e2114b
43b2908
48b4f71
5b0c124
488f426
c92b783
1a1ee00
a5e6472
b226a5e
d98aa1c
bed622e
4fe8d7f
2c62a49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to have a separate file for the tokens? sqlite is already an option for the user data, guess we can have a new table in the same file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is related to the separate sqlite file: What's the reason for switching to sqlx when we already have GORM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see now that it is integrated with oauth. Maybe we can investigate this further. Having two different databases increases complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very clean, but it is possible to use the same mysql database for auth and pushbits itself by just using the same credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to improve that one step further - oauth now does not need any further storage information. If the main db is mysql, oauth uses just the same database and if it is sqlite3 it uses its own sqlite file.
Unfortunately I was not yet able to share the main sqlite with oauth. For that I'd need a sqlx object with the sqlite - which I am able to generate but it then runs in "command unknown" errors as soon as actions are performed on it.