-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog on data & insights (1/11) #4505
Conversation
Thanks amrutha95 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, its a quick read and provides a general overview on the subject matter. I think it would be good to link out to more resources for the reader to take action on. Also, more links to PWABuilder itself if at all possible.
Merge blog updates.
Hot fix for Blog back button --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like this is mostly there. Just wording and adding links, except for one content suggestion at the very end.
Thanks, Amrutha
#4412 --------- Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: Beth Pan <[email protected]>
## PR Type <!-- Please uncomment one ore more that apply to this PR --> - Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? If a post has an updatedDate, it shows up twice ## Describe the new behavior? It only shows up once
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this blog post - left comments
Co-authored-by: Nikola Metulev <[email protected]>
…Builder into amrutha-blogpost
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-4505.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-4505.eastus2.azurestaticapps.net |
fixes #4413 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... Please describe: Blogpost ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This was originally a different PR targeting staging (#4505) --------- Co-authored-by: Amrutha Srinivasan <[email protected]>
Close as #4534 is merged into main directly. |
fixes #4413
PR Type
Other... Please describe: Blogpost
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run test
and ensure that all tests passAdditional Information