Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to importlib.resources #114

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Port to importlib.resources #114

merged 4 commits into from
Aug 18, 2023

Conversation

stefanor
Copy link
Collaborator

Port from pkg_resources to importlib.resources

(Closes: #113)

@stefanor
Copy link
Collaborator Author

Do we really still need to carry 2.7 support?

@pwaller
Copy link
Owner

pwaller commented Aug 10, 2023

Thanks for this! I'm not averse to dropping 2.7 in principle. It's nice to have but if the effort to keep it is too great, then we should drop it. If someone needs it they are welcome to contribute support.

Would you be able to drop it from the CI so we can get tests passing? I'm happy to cut a release quickly for this.

@pwaller
Copy link
Owner

pwaller commented Aug 10, 2023

Speedy 🚀

@stefanor
Copy link
Collaborator Author

OK, the tests are now failing because we have fonts that don't parse.

I think this was a pre-existing issue, but wasn't noticed because getFonts was returning an empty list (fixed in the first commit here)

@stefanor
Copy link
Collaborator Author

I'm running out of time to look at this right now.

@pwaller
Copy link
Owner

pwaller commented Aug 10, 2023

Thank you for taking some time to look. I'll be away for the next week or so.

@stefanor
Copy link
Collaborator Author

stefanor commented Aug 11, 2023 •
edited
Loading

I'll rebase out the commit that's triggering the bug (9b77825), and we can deal with that separately. (#115)

@stefanor
Copy link
Collaborator Author

Yeah, CI passes now.

@stefanor
Declare ourselves to be Python 3.x-only
d90b5b9 
importlib.resources was added in 3.7, so set that as the minimum Python
3 version.
@pwaller
Copy link
Owner

pwaller commented Aug 18, 2023

Thanks so much for taking the time to get to the bottom of this 🥇. Changes look good to me.

@pwaller pwaller merged commit 51ec0a2 into master Aug 18, 2023
3 checks passed
@pwaller pwaller deleted the importlib branch August 18, 2023 21:01
This was referenced Aug 18, 2023
Merged
Closed
Closed
@peterbrittain peterbrittain mentioned this pull request Aug 30, 2023
Closed
@pwaller pwaller mentioned this pull request Sep 11, 2023
Merged
pwaller added a commit that referenced this pull request Sep 11, 2023
@pwaller
Add requires-python >= 3.9
9928e16 
This is in response to #114, which requires importlib.resources.files.
pwaller added a commit that referenced this pull request Sep 11, 2023
@pwaller
Add requires-python >= 3.9
c2acf49 
This is in response to #114, which requires importlib.resources.files.
pwaller added a commit that referenced this pull request Sep 11, 2023
@pwaller
Add python_requires >= 3.9
3b52934 
This is in response to #114, which requires importlib.resources.files.
pwaller added a commit that referenced this pull request Sep 11, 2023
@pwaller
Add python_requires >= 3.9
93aa713 
This is in response to #114, which requires importlib.resources.files.
@pwaller pwaller mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from pkg_resources to importlib
2 participants
@stefanor @pwaller