Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors arising under formulaic>=1.1.0 #786

Merged
merged 5 commits into from
Jan 12, 2025
Merged

Fix errors arising under formulaic>=1.1.0 #786

merged 5 commits into from
Jan 12, 2025

Conversation

s3alfisc
Copy link
Member

For details, see here and here.

Reason for the bug: formulaic no longer adds a T. prefix before categorical variables. As a result, regex operations failed.
This led to loud errors in the fixef() methods, but silent failures when variables where interacted via i() with a reference level set via i(..., ref): the reference level would not be dropped from the design matrix X.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/utils/dev_utils.py 85.71% 1 Missing ⚠️
Flag Coverage Δ
core-tests 82.55% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/model_matrix_fixest_.py 85.32% <100.00%> (ø)
pyfixest/utils/dev_utils.py 83.78% <85.71%> (-0.43%) ⬇️

@s3alfisc s3alfisc merged commit 306da82 into master Jan 12, 2025
9 checks passed
@s3alfisc s3alfisc deleted the formulaic-bug branch January 12, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixef() encoding fails under formulaic>=1.1.0 Issue computing fixed effects
1 participant