Fix errors arising under formulaic>=1.1.0
#786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see here and here.
Reason for the bug:
formulaic
no longer adds aT.
prefix before categorical variables. As a result, regex operations failed.This led to loud errors in the
fixef()
methods, but silent failures when variables where interacted viai()
with a reference level set viai(..., ref)
: the reference level would not be dropped from the design matrix X.