-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated cd workflow and Python Semantic Release table in pyproject.toml #71
Conversation
This new cd workflow the the following changes: - uses a GHA for Python Semantic Release instead of a command Python Semantic Release version 8.3.0 - upgraded to - drops the now redundant GHA commands (Install poetry, Install package) - added a conditional to publish to the package repositories (only do this if semantic release has a new release - used a GHA to generate the GitHub release
This changes require the new table in
A couple notes:
I think the only docs we need to update are the book for this table? Currently working here to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool this looks great to me - I remember having quite a bit of trouble getting PSR to work with GH Actions. Fantastic that they have their own action now, seems to have simplified things.
@ttimbers - we want to modify the
|
We actually do not need:
So it just needs to be:
And yes, we should edit the |
oops! I accidentally directly added it to Apologies, should have branched and PR'ed it (meant to but was using the pen tool and clicked the wrong radio button). Should we add main branch protection to this repo 😅 |
This new cd workflow the the following changes: