[WIP] improve Binarize() performance #1721
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing long audios in the
SpeakerDiarization
pipeline, I noticed that theto_annotation()
method was taking a while, and I tracked it down topyannote.audio.utils.signal.Binarize.__call__()
where it was looping over a numpy array which could end up being quite large.In my tests, the original implementation took about 60 seconds for a 9 hour audio. With this new implementation, it takes about 0.5 seconds.
I've only tested this with the SpeakerDiarization pipeline, but the new implementation returns the same results as the original.