-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the cerrado
sequential colormap
#69
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 155 155
Lines 1981 1982 +1
=======================================
+ Hits 1919 1920 +1
Misses 62 62 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thanks again for your contributions!
cerrado
sequential colormapcerrado
sequential colormap
Happy to contribute! I'm curious why the perceptual lightness increases linearly in the documentation. Since I didn't use CAM02-UCS and the |
If you're curious to see how it's generated, the code used to calculate the y values for that chart is in |
Might be a javascript/chart issue actually... if you hover on the delta values they range very similarly to your data, between 50-60 or so... actually might just be a weirdly scaled right axis |
The perceptual lightness curve appears incorrect; it should exhibit a slight bump rather than being a straight line. However, I did not find any apparent issues with the code. Maybe the curves are there but it is very subtle. |
i believe it's just the scaling of the Y axis: hover over the values and you'll see that the deltas match the perceptual lightness derivative from your graph (ranging from ~50 to 60+ and then back down a bit): I pinned the range of deltas (right Y axis) to -500 --> + 500 globally right here. This was so that A) one could generally look at many colormaps and say "is this generally linear compared to the others" without having to carefully look at the Y axis and know what range other colormaps have, ... and so that B) the grid on the graph is clean I can see that it gives the impression in your colormap of perfect linearity, while it is in fact, slightly nonlinear. But, relative to some others, it is indeed rather linear. Open to suggestions if you'd like to suggest a new presentation option |
Yeah, I think you're right. I don't have any suggestions, it looks pretty good as is. Other than changing the range of the right Y axis, I don't see any other way to "fix" this. Is there any reason you set a large interval there? |
that was what I was trying to explain above:
to clarify: -500-+500 was a range that fit the the full range of deltas seen across all colormaps, so, for example, turbo covers a decent part of it: and others probably cover even more. it does seem a bit random and large for a one-off linear colormap. but that was the intention (to foster comparisons against others) see also https://cmap-docs.readthedocs.io/en/latest/catalog/miscellaneous/yorick%3Ancar/ |
Ohh, I understand it now. I don't see any reason for a change then. It's pretty good like this. I doubt such small deviations from a linear colormap are relevant enough to justify any changes. |
Thanks for the eagle-eyed question :) |
This PR adds the
cerrado
sequential colormap to thecontrib
namespace. This was created by interpolating three colors (#6e2504
,#e1344b
, and#f3ccba
) with natural spline in the OKLAB space using thecoloraide
library.That's the last one of colormaps that I have to contribute for the meanwhile.