fix ec reaction bug (#4774)

fix bugs
pybamm-team · Jan 17, 2025 · ef8571c · ef8571c
1 parent c9cb2bb
commit ef8571c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/pybamm/models/submodels/interface/sei/sei_growth.py b/src/pybamm/models/submodels/interface/sei/sei_growth.py
@@ -186,7 +186,6 @@ def get_coupled_variables(self, variables):
             #  j = -F * c_0* k_exp() / (1 + L * k_exp() / D)
             #  c_ec = c_0 - L * k_exp() / D / (1 + L * k_exp() / D)
             #       = c_0 / (1 + L * k_exp() / D)
-            eta_SEI = delta_phi
             k_exp = phase_param.k_sei * pybamm.exp(-alpha_SEI * F_RT * eta_SEI)
             L_over_D = L_sei / phase_param.D_ec
             c_0 = phase_param.c_ec_0

diff --git a/src/pybamm/simulation.py b/src/pybamm/simulation.py
@@ -895,7 +895,6 @@ def solve(
                     logs["summary variables"] = cycle_sum_vars
 
                 # Calculate capacity_start using the first cycle
-                capacity_stop = None
                 if cycle_num == 1:
                     # Note capacity_start could be defined as
                     # self._parameter_values["Nominal cell capacity [A.h]"] instead
@@ -907,6 +906,8 @@ def solve(
                             capacity_stop = value
                         elif typ == "%":
                             capacity_stop = value / 100 * capacity_start
+                    else:
+                        capacity_stop = None
                     logs["stopping conditions"]["capacity"] = capacity_stop
 
                 logs["elapsed time"] = timer.time()