Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create battery benchmark methods #644

Draft
wants to merge 34 commits into
base: develop
Choose a base branch
from

Merge branch 'develop' into 124-battery-benchmarks

aee86dd
Select commit
Loading
Failed to load commit list.
Draft

Create battery benchmark methods #644

Merge branch 'develop' into 124-battery-benchmarks
aee86dd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 4, 2025 in 0s

98.12% (-1.16%) compared to 24c54d9

View this Pull Request on Codecov

98.12% (-1.16%) compared to 24c54d9

Details

Codecov Report

Attention: Patch coverage is 79.29825% with 59 lines in your changes missing coverage. Please review.

Project coverage is 98.12%. Comparing base (24c54d9) to head (aee86dd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/models/lithium_ion/weppner_huggins.py 41.86% 25 Missing ⚠️
pybop/models/lithium_ion/basic_SP_diffusion.py 81.03% 22 Missing ⚠️
pybop/applications/gitt_methods.py 57.14% 12 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #644      +/-   ##
===========================================
- Coverage    99.27%   98.12%   -1.16%     
===========================================
  Files           64       68       +4     
  Lines         4813     5060     +247     
===========================================
+ Hits          4778     4965     +187     
- Misses          35       95      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov