Pin Certbot dependencies during testing #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
We're happy to use whatever script you use, so |
reaperhulk
approved these changes
Jun 1, 2020
|
@bmw really appreciate how quickly y'all jumped on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the latest version of one of Certbot's dependencies is broken on Python 2.7. See bear/parsedatetime#246. This PR fixes things by pinning Certbot's dependencies to known working versions.
A custom installation script is used because we have multiple requirements files you'd have to use to pin everything down and some of them contain hashes which causes
pipto error when installing packages in editable mode. We could resolve these problems a different way here if you prefer, but the script we use upstream takes care of these problems.