Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose wrapped iterator in SerializationIterator #1399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yorickvP
Copy link

Change Summary

We're currently working around pydantic#8907 by parsing the pointer out of the repr(). To make this workaround slightly better, we'd like to expose the wrapped iterator in SerializationIterator via .iterator.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (ab503cb) to head (6e3ed61).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   90.21%   89.54%   -0.68%     
==========================================
  Files         106      109       +3     
  Lines       16339    17348    +1009     
  Branches       36       41       +5     
==========================================
+ Hits        14740    15534     +794     
- Misses       1592     1794     +202     
- Partials        7       20      +13     
Files Coverage Δ
src/serializers/type_serializers/generator.rs 81.39% <ø> (-13.46%) ⬇️

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a6b10...6e3ed61. Read the comment docs.

@yorickvP
Copy link
Author

Test failure looks unrelated.

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #1399 will not alter performance

Comparing yorickvP:yorickvp/expose-sit-iterator (6e3ed61) with main (39a6b10)

Summary

✅ 155 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get a final review by either @davidhewitt or @samuelcolvin.

Thanks for your patience with this review process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants