Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Two small bug fixes to search-as-you-type #2111

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@ var setupSearchAsYouType = () => {

// Don't search when there's nothing in the query textbox.
if (query === "") {
lastQuery = "";
resetSearchAsYouTypeResults(); // Remove previous results.
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@
margin: 15vh auto 0; // an open modal dialog has a fixed position, so these margins bring it 15% down the viewport height and center it horizontally
width: 90%;
max-width: 800px;
max-height: 80vh; // when we display search-as-you-type results in the modal, it needs to be able to expand in height
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why I didn't see this the first time around, but yeah, the simple solution is to apply a max-height on the search dialog, not to toggle a height class 🙈

background-color: transparent;
padding: $focus-ring-width;
border: none;
height: 80vh;

&::backdrop {
background-color: black;
Expand Down
Loading