-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more friendly error message in case no chunk manager is available #9676
Open
keewis
wants to merge
12
commits into
pydata:main
Choose a base branch
from
keewis:no-chunkmanager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1f71dac
raise an error message while guessing if there's no chunkmanager avai…
keewis 66ed78c
don't skip the no chunkmanager test if dask is not installed
keewis 1dba7b0
Merge branch 'main' into no-chunkmanager
keewis 04d605c
whats-new
keewis b1d4017
ensure at least one chunk manager is available
keewis ab335a9
Merge branch 'main' into no-chunkmanager
keewis 4119473
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f9d1fcc
remove additional blank line from a bad merge
keewis e3cd03e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c646c29
improve the wording
keewis 7bb3433
switch to ImportError
dcherian 5f27715
Merge branch 'main' into no-chunkmanager
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there might be two reasons why this fails: one, there's a typo, in which case I'd say it would be better to raise a
ValueError
(the issue is the caller's input), while the second reason is indeed that the library that provides the requested chunk manager was not installed or fails to import.In the case when there's no chunk manager at all, we know that the user needs to install a library and I can understand using a
ImportError
. However, in the case where there's at least one chunk manager I don't think we can figure out whether the issue was a user error or a missing library (at least, without maintaining a list of known chunk managers and suggesting sufficiently "close" names), so I think this should still be expecting aValueError
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You raise a good point about ambiguity, but I also think we could reasonably just say (imprecisely) "with this user input were unable to import a necessary library, so there's still an
ImportError
underneath", which then has the advantage of consistency of error types for users.