Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add population of __dict__ variable with __events__, if present. #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion events/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ class Events:

xxx.OnChange = event('OnChange')
"""

def __init__(self, events=None, event_slot_cls=_EventSlot):
self.__event_slot_cls__ = event_slot_cls

if events is not None:

try:
for _ in events:
break
Expand All @@ -83,6 +83,12 @@ def __init__(self, events=None, event_slot_cls=_EventSlot):
else:
self.__events__ = events

if hasattr(self, '__events__'):
self.__dict__ = dict(
{name: self.__event_slot_cls__(name) for name in self.__events__},
**self.__dict__
)

def __getattr__(self, name):
if name.startswith('__'):
raise AttributeError("type object '%s' has no attribute '%s'" %
Expand Down
33 changes: 33 additions & 0 deletions events/tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ def test_getitem(self):
pass
else:
self.fail("IndexError expected.")

def test_getitem_bystring(self):

class MyEvents(Events):
__events__ = ('on_event_one', 'on_event_two')

ev = self.events.on_edit
self.assertIs(ev, self.events["on_edit"])
self.assertIsNot(ev, self.events["on_change"])
try:
Expand All @@ -126,6 +133,32 @@ def test_getitem(self):
pass
else:
self.fail("KeyError expected.")
my_events = MyEvents()
self.assertIs(my_events.on_event_one, my_events["on_event_one"])
self.assertIs(my_events.on_event_two, my_events["on_event_two"])
try:
my_events["on_nonexistent_event"]
except KeyError:
pass
else:
self.fail("KeyError expected.")
events = Events()
try:
events["on_event_one"]
except KeyError:
pass
else:
self.fail("KeyError expected.")
events = Events(("on_event_three", "on_event_four"))
self.assertIs(events.on_event_three, events["on_event_three"])
self.assertIs(events.on_event_four, events["on_event_four"])
try:
events["on_event_one"]
except KeyError:
pass
else:
self.fail("KeyError expected.")


def test_isub(self):
self.events.on_change -= self.callback1
Expand Down