Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CPUHashMap and CUDAHashMap implementations #393

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Feb 1, 2025

No description provided.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.85%. Comparing base (ef72b03) to head (0d5da7c).

Files with missing lines Patch % Lines
pyg_lib/csrc/classes/cpu/hash_map.cpp 90.62% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   87.17%   86.85%   -0.32%     
==========================================
  Files          38       36       -2     
  Lines        1193     1210      +17     
==========================================
+ Hits         1040     1051      +11     
- Misses        153      159       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 04eff96 into master Feb 1, 2025
10 checks passed
@rusty1s rusty1s deleted the align_cpp branch February 1, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant