Add some default NVTX ranges #7633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7633 +/- ##
==========================================
- Coverage 90.44% 89.75% -0.69%
==========================================
Files 455 456 +1
Lines 26334 26406 +72
==========================================
- Hits 23818 23702 -116
- Misses 2516 2704 +188
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Serge Panev <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Serge Panev <[email protected]>
Signed-off-by: Serge Panev <[email protected]>
Signed-off-by: Serge Panev <[email protected]>
|
LGTM! |
akihironitta
reviewed
Aug 4, 2023
| "0") == "1" and torch.cuda.is_available(): | ||
| self._nvtx_handles = dict() | ||
|
|
||
| def get_hooks_for(func_name): |
There was a problem hiding this comment.
I think this is not an issue if NVIDIA_NVTX_RANGES is not meant to be used by the community, but I prefer to define the hook at the top-level to avoid PicklingError in a multiprocessing setting. https://docs.python.org/3/library/pickle.html#what-can-be-pickled-and-unpickled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages torch's NVTX API to add default nvtx ranges to help profiling with nsys. Those can be enabled with the
NVIDIA_NVTX_RANGESenvironment variable.How to use:
Result
It adds ranges for the following functions:
Dataloaders'scollate_fnDataset's__getitem__MessagePassing's main member functionsNeighborSampler's