-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exphormer
Implementation
#9783
base: master
Are you sure you want to change the base?
Exphormer
Implementation
#9783
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, I think this PR is now ready for review Thanks in advance! |
Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, I think the PR is ready to review, all conflicts are resolved!! |
Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, please provide an ETA for review... |
Hi, @phoeenniixx I just submitted a PR for SGFormer. You can check it and determine how your work could be better integrated into torch_geometric. Like but not limited
|
Thanks for the reply @xnuohz, been a little busy lately, I will make the changes in few days :) |
hi @phoeenniixx, i can get this merged after review. to start off can you share a log of the example run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1)please put the model under torch_geometric.nn.models and the test under test/nn/model
- then please make an example of running this as an additional model option for examples/ogbn-train.py. do this with "--gnn-choice" arg parse option, with choices ["sage, gat, exphormer_graph_transformer"].
then run all 3 and share the logs. make the default the highest scoring one
you also need a unit test for the submodules under test/nn/attention
(i will have other PRs for GraphTrasnformers follow this design pattern so its unified)
Implementing Exphormer based on this paper
See also #9751