-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for LargeGraphIndexer
from_triples ordering issue
#9952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever we fix something, we need to include a unit test in the same PR
good idea, will do |
for more information, see https://pre-commit.ci
I'm not yet the right person to review this change.
as it cannot be reviewed i will close this and let it be merged as part of my large main PR somehow down the line. i will likely have ot do a live code walkthrough or something to bringup to speed |
cc @zaristei
This fixes the ordering if using this init function. Found through my txt2kg PR.
#9846
Further less important changes in my txt2kg PR which I will get merge ready soon