Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for LargeGraphIndexer from_triples ordering issue #9952

Closed
wants to merge 12 commits into from

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Jan 15, 2025

cc @zaristei
This fixes the ordering if using this init function. Found through my txt2kg PR.
#9846

Further less important changes in my txt2kg PR which I will get merge ready soon

@puririshi98 puririshi98 self-assigned this Jan 15, 2025
@github-actions github-actions bot added the data label Jan 15, 2025
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we fix something, we need to include a unit test in the same PR

@puririshi98
Copy link
Contributor Author

puririshi98 commented Jan 21, 2025

Whenever we fix something, we need to include a unit test in the same PR

good idea, will do

@puririshi98 puririshi98 requested a review from wsad1 as a code owner January 24, 2025 19:46
pre-commit-ci bot and others added 2 commits January 24, 2025 19:47
for more information, see https://pre-commit.ci
puririshi98 and others added 5 commits January 24, 2025 13:31
for more information, see https://pre-commit.ci
@akihironitta akihironitta dismissed their stale review January 30, 2025 09:38

I'm not yet the right person to review this change.

@puririshi98
Copy link
Contributor Author

as it cannot be reviewed i will close this and let it be merged as part of my large main PR somehow down the line. i will likely have ot do a live code walkthrough or something to bringup to speed

@puririshi98 puririshi98 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants