pre-pr changes

pyinfra/api/command.py

@@ -223,25 +223,13 @@ def execute(self, state: "State", host: "Host", connector_arguments: ConnectorAr
         if "state" in argspec.args and "host" in argspec.args:
             return self.function(state, host, *self.args, **self.kwargs)
 
-        # Note: we use try/except here to catch any exception inside the greenlet
-        # and bubble that back out as a return value before re-raising outside.
-        # This is because gevent dumps stack traces when raised within a greenlet
-        # and we want to handle that ourselves.
         def execute_function():
             with ctx_config.use(state.config.copy()):
                 with ctx_host.use(host):
-                    try:
-                        self.function(*self.args, **self.kwargs)
-                    except Exception as e:
-                        return e
-                    else:
-                        return True
+                    self.function(*self.args, **self.kwargs)
 
         greenlet = gevent.spawn(execute_function)
-        res = greenlet.get()
-        if isinstance(res, Exception):
-            raise res
-        return res
+        return greenlet.get()
 
 
 class RsyncCommand(PyinfraCommand):

pyinfra/api/exceptions.py

@@ -4,12 +4,6 @@ class PyinfraError(Exception):
     """
 
 
-class NoMoreHostsError(PyinfraError):
-    """
-    Exception raised when pyinfra runs out of hosts (they all failed).
-    """
-
-
 class ConnectError(PyinfraError):
     """
     Exception raised when connecting fails.

pyinfra/api/operation.py

@@ -397,9 +397,7 @@ def execute_immediately(state, host, op_hash):
     op_data = state.get_op_data_for_host(host, op_hash)
     op_data.parent_op_hash = host.executing_op_hash
     log_operation_start(op_meta, op_types=["nested"], prefix="")
-    status = run_host_op(state, host, op_hash)
-    if status is False:
-        state.fail_hosts({host})
+    run_host_op(state, host, op_hash)
 
 
 def _get_arg_value(arg):

pyinfra/operations/dnf.py

@@ -115,7 +115,7 @@ def rpm(src: str, present=True):
         )
     """
 
-    yield from ensure_rpm(state, host, src, present, "dnf")
+    yield from ensure_rpm(host, src, present, "dnf")
 
 
 @operation(is_idempotent=False)

pyinfra/operations/mysql.py

@@ -75,7 +75,6 @@ def user(
     mysql_host: str = None,
     mysql_port: int = None,
 ):
-    ...
     """
     Add/remove/update MySQL users.
 
@@ -297,7 +296,6 @@ def database(
     mysql_host: str = None,
     mysql_port: int = None,
 ):
-    ...
     """
     Add/remove MySQL databases.
 

pyinfra/operations/python.py

@@ -2,10 +2,7 @@
 The Python module allows you to execute Python code within the context of a deploy.
 """
 
-from inspect import getfullargspec
 from typing import Callable
-
-from pyinfra import logger
 from pyinfra.api import FunctionCommand, operation
 
 

pyinfra/operations/util/packaging.py

@@ -158,7 +158,6 @@ def ensure_packages(
 
 
 def ensure_rpm(
-    state: State,
     host: Host,
     source: str,
     present: bool,

pyinfra/operations/yum.py

@@ -115,7 +115,7 @@ def rpm(src: str, present=True):
         )
     """
 
-    yield from ensure_rpm(state, host, src, present, "yum")
+    yield from ensure_rpm(host, src, present, "yum")
 
 
 @operation(is_idempotent=False)

pyinfra/operations/zypper.py

@@ -91,7 +91,7 @@ def rpm(src, present=True):
         )
     """
 
-    yield from ensure_rpm(state, host, src, present, "zypper --non-interactive")
+    yield from ensure_rpm(host, src, present, "zypper --non-interactive")
 
 
 @operation(is_idempotent=False)