Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NetworkDevices Fact #1037

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Update NetworkDevices Fact #1037

merged 2 commits into from
Nov 26, 2023

Conversation

maisim
Copy link
Contributor

@maisim maisim commented Nov 20, 2023

  • Add mtu, state, mac adress, to the output
  • Refactoring

@maisim maisim force-pushed the update_network_devices branch from 275c2c3 to 909f57c Compare November 20, 2023 14:09
@maisim @Fizzadar
Update NetworkDevices Fact
3fd3f07 
* Add mtu, state, mac adress, to the output
* Refactoring
@Fizzadar Fizzadar force-pushed the update_network_devices branch from 909f57c to 3fd3f07 Compare November 26, 2023 19:49
@Fizzadar
Always include broadcast in IPv4 info
5adb298 
Fixes union operand not being allowed for dicts in Python <3.9.
Fizzadar
Fizzadar approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @maisim, this is a great improvement! Pushed a little compat fix for Python <3.9, hope to release this in the upcoming week.

@Fizzadar Fizzadar merged commit 8c2751d into pyinfra-dev:2.x Nov 26, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fizzadar Fizzadar Fizzadar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maisim @Fizzadar