Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy error and update ssh test to get around paramiko config parser issue #1041

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

maisim
Copy link
Contributor

@maisim maisim commented Nov 22, 2023

Fix error:
pyinfra/api/config.py:57: error: Unsupported operand types for in ("Version" and "Requirement") Found 1 error in 1 file (checked 122 source files)

Fix error:
pyinfra/api/config.py:57: error: Unsupported operand types for in ("Version" and "Requirement")
Found 1 error in 1 file (checked 122 source files)
Temporary workaround to get tests/test_connectors/test_sshuserclient.py

That's seems paramiko 3 config parser dislike None value (to be confirmed)
@maisim maisim force-pushed the fix_mypy_error_in_config_py branch from 2f3a50b to 89d7544 Compare November 23, 2023 10:54
@maisim maisim changed the title Fix mypy error Fix mypy error and update ssh test to get around paramiko config parser issue Nov 23, 2023
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you fixing these two @maisim 🙏

@Fizzadar Fizzadar merged commit 02a154c into pyinfra-dev:2.x Nov 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants