Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server Users fact when user description contains a pipe character #1045

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

julienlavergne
Copy link
Contributor

@julienlavergne julienlavergne commented Dec 8, 2023

There is an unrecoverable exception when one of the user description does contains a pipe.

@Fizzadar It makes the entire Users fact not usable, and prior versions of pyinfra also have the issue. It would be great to have a new version released after this is merged.

@maisim
Copy link
Contributor

maisim commented Dec 8, 2023

Hi @julienlavergne
Well see
It should be nice to remove the 2 last commits from you pr has they are useless, you can reset your branch to 1d32b10
On your 'patch-1' branch you can:

git reset 1d32b100d09db580ccd0438f1d5d69af013ad515
git push origin --force
where 'origin' is your fork remote name

@Fizzadar Fizzadar merged commit 8e2c991 into pyinfra-dev:2.x Jan 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants