Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for opkg (OpenWrt's package manager) #1053

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

morrison12
Copy link
Contributor

Initial support for opkg ( Openwrt's package manager).
Addresses issue #1046.

@morrison12
Copy link
Contributor Author

morrison12 commented Jan 4, 2024

Although this is only opkg, should I rename it to openwrt and thus if any other OpenWrt-specifics (e.g. ProcD, UCI) happen along the could be grouped together. Either way works for me.

Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @morrison12! Apologies for the long delay reviewing this. Looks great overall, esp the test coverage! Couple of minor tweaks needed, I’m happy to make these changes when I have the time too if you don’t get there first!

pyinfra/operations/opkg.py Outdated Show resolved Hide resolved
pyinfra/facts/opkg.py Outdated Show resolved Hide resolved
@Fizzadar
Copy link
Member

Fizzadar commented Mar 2, 2024

@morrison12 would you mind giving me write permissions on this branch? I'll fixup those issues to land this

@morrison12
Copy link
Contributor Author

@morrison12 would you mind giving me write permissions on this branch? I'll fixup those issues to land this

Done. Apologies for delay: real life exceeding its quota right now..

@Fizzadar Fizzadar added this to the v3.1 milestone Jun 25, 2024
@Fizzadar Fizzadar changed the base branch from 2.x to 3.x August 10, 2024 12:34
@Fizzadar Fizzadar modified the milestones: v3.1, v3.2 Aug 10, 2024
@Fizzadar Fizzadar force-pushed the openwrt-opkg branch 5 times, most recently from 4daf851 to a71caf9 Compare November 17, 2024 13:57
@Fizzadar Fizzadar merged commit 85113b1 into pyinfra-dev:3.x Jan 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants