-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hints for operations #1081
Closed
stone-w4tch3r
wants to merge
15
commits into
pyinfra-dev:2.x
from
stone-w4tch3r:type_hints_operations
Closed
Type hints for operations #1081
stone-w4tch3r
wants to merge
15
commits into
pyinfra-dev:2.x
from
stone-w4tch3r:type_hints_operations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stone-w4tch3r
force-pushed
the
type_hints_operations
branch
from
April 5, 2024 13:54
40919e3
to
e104f7e
Compare
Looks like some automatic checks are broken, even on 2.x branch |
@stone-w4tch3r I'm going to close this one to focus on v3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1074, type hints would be useful in operations ;-)
Added type hints to all operations, minor documentation fixes, minor warning fixes, minor variable renamings