PyinfraOperation: Put *args first so that mypy correctly handles inner operation args #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r operation args
This is not a mypy issue - unnamed arguments are passed in order so if
PyinfraOperation were a real class instead of a protocol then
PyinfraOperation.__call__("a", "b") would pass "a" and "b" to _sudo and
_sudo_user.
This is the minimum fix to avoid errors like these:
pyinfra_deploy.py:6: error: Too few arguments for "__call__" of "PyinfraOperation" [call-arg]
pyinfra_deploy.py:7: error: Argument 1 to "__call__" of "PyinfraOperation" has incompatible type "str"; expected "bool" [arg-type]
Fizzadar
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a mypy issue - unnamed arguments are passed in order so if PyinfraOperation were a real class instead of a protocol then PyinfraOperation.call("a", "b") would pass "a" and "b" to _sudo and _sudo_user.
This is the minimum fix to avoid errors like these:
I saw #1082 and this change is not included