Update dev dependencies and clean up mypy errors #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martenlienen
force-pushed
the
update-and-clean-up
branch
from
345e85f to
02ec3d4
Compare
|
@Fizzadar Now that the minimum supported python version is 3.8, this PR also works |
Fizzadar
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to start working on a small fix when I noticed that
pytestgave me over 1,000 warnings on python 3.12. So I took the opportunity to update the test dependencies. Everything still works, warnings are down to 47 and code coverage gives the same numbers while feeling a bit faster. I did not measure. While I was at it, I also upgraded the formatting dependencies and tacked on a small fix of two typing errors that mypy complains about.Best,
Marten