-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more arguments in FindFilesBase #1188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, huge improvement! Few linting things to fix and this is ready I think.
Just fixed linting. |
I'm not sure how to express |
f0261ea
to
ef2568e
Compare
finally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just the test thing (I'll move and merge if I get to it before you :)).
628f230
to
ab8537c
Compare
cleanup & add source
396c304
to
5762944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JakkuSakura this is really awesome, thank you! Sorry it's taken me so long to review it. I've pushed up a quick fix for the tests (also made a mess on rebase first, but fixed).
Much appreciated! It's my first PR for pyinfra and the lining has cost me some time, but eventually figured out how to do it properly |
Would love any comments/ideas/etc on how to make the experience better when contributing 🙏 |
This is an attempt to make FindFiles more useful.
It has not been tested yetcloses #1174