get_join_indices function #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samukweku
requested review from
ericmjl,
hectormz,
loganthomas,
Zeroto521 and
thatlittleboy
|
🚀 Deployed on https://deploy-preview-1312--pyjanitor.netlify.app |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1312 +/- ##
==========================================
+ Coverage 93.91% 94.49% +0.58%
==========================================
Files 78 78
Lines 4254 4254
==========================================
+ Hits 3995 4020 +25
+ Misses 259 234 -25 |
ericmjl
reviewed
Dec 13, 2023
ericmjl
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Pre-approving the PR, @samukweku. I have only one comment about the name of return_indices as an argument.
added 8 commits
December 14, 2023 09:11
…ays return a dataframe from a chain
|
@ericmjl i created a separate function to return join indices - keeping the existing function as is. I feel it'd align more with pyjanitor's original goal of ensuring a dataframe is always returned. |
|
@samukweku I'm good with the latest changes! Thank you for working hard on this PR. Are you good for merging? |
|
Okie dokes, saw your thumbs up, let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #1310 .
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.