-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] : Implementation of read_archive function #1438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sabrina-Hassaim thank you for kickstarting this PR! It was a relatively easy one to review, and I just happened to have a small chunk of time to review it. I'm going to request changes here, as it seems to me that anything related to I/O should live in io.py
and follow the patterns there. Once we're done with these changes and @samukweku has reviewed, I think we can merge and cut a new release.
@Sabrina-Hassaim thanks for the PR.there are some failed checks in the ci. Kindly fix that before the maintainers review. |
Hello @samukweku! Thanks for your response. I’m encountering an issue with building the documentation using mkdocs, and I believe it’s related to the AUTHORS.md file. Here’s what I did: I added my name to the AUTHORS.md file located in the root directory. In the mkdocs.yml configuration file, the AUTHORS.md file is referenced in the navigation section, but it points to mkdocs/AUTHORS.md, which contains a relative reference (../AUTHORS.md) to the root file. However, when I try to build the documentation, it fails both locally and on GitHub Actions with the following error: ERROR - File not found: AUTHORS.md It seems the ../AUTHORS.md reference in mkdocs/AUTHORS.md is not being resolved correctly. Locally, I ran make docs in my environment, but the same error occurs. Do you have an idea how should I handle this issue? Would it be acceptable to point mkdocs.yml directly to the root AUTHORS.md file instead of using the relative reference? Thanks in advance for your guidance! Let me know if more details are needed. |
5890838
to
ba6f4fc
Compare
PR Description
Please describe the changes proposed in the pull request:
1. Implementation of the read_archive Function:
2. Unit Tests
This PR resolves #(put issue number here, and remove parentheses).
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.